feature: add virtual threads to LoadEngine and validation tests#15
Merged
feature: add virtual threads to LoadEngine and validation tests#15
Conversation
devcrocod
approved these changes
Mar 12, 2026
Collaborator
There was a problem hiding this comment.
It's not very clear why the tests were removed
|
|
||
| try (HttpSender sender = new HttpSender()) { | ||
| try (HttpSender sender = new HttpSender(); | ||
| ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor()) { |
Collaborator
There was a problem hiding this comment.
The number of threads can grow without limit, and eventually no amount of memory will be enough
| while (System.nanoTime() < sendNextTime) { | ||
| // busy-wait | ||
| } | ||
| long waitMillis = (sendNextTime - System.nanoTime()) / 1_000_000; |
Collaborator
There was a problem hiding this comment.
With this calculation, waitMillis may become 0, which will cause the sleep to be skipped and the requests to be sent immediately
| log.error("Sender closed or failed to initialize", e); | ||
| } | ||
|
|
||
| running = false; |
Collaborator
There was a problem hiding this comment.
It’s not obvious how the entire process terminates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrade
LoadEngineto use Virtual Threads for request execution.Each HTTP request is now submitted as a separate Virtual Thread task via
ExecutorService,so the main loop is no longer blocked waiting for responses.
Also added:
Thread.sleep()to reduce CPU usageHow to verify
./mvnw test
Closes #10